Change global arp ignore level from "check ip within same subnet" to "all reply" #18785
Conversation
|
|
irene-pan1202
force-pushed
the
arp_ignore
branch
from
80887fe to
2a233ee
Compare
irene-pan1202
force-pushed
the
arp_ignore
branch
from
2a233ee to
bbff4d7
Compare
…"all reply" Support arp_reply in port/vlan/portchannel yang Signed-off-by: irene_pan <[email protected]>
irene-pan1202
force-pushed
the
arp_ignore
branch
from
bbff4d7 to
718c5b2
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can you please share the motivation of this PR? |
| @@ -14,7 +14,6 @@ net.ipv4.conf.all.arp_accept=0 | |||
| net.ipv4.conf.all.arp_announce=1 | |||
| net.ipv4.conf.all.arp_filter=0 | |||
| net.ipv4.conf.all.arp_notify=1 | |||
| net.ipv4.conf.all.arp_ignore=2 | |||
There was a problem hiding this comment.
Do not change default values that break backward compatibility.
There was a problem hiding this comment.
According to linux documentation, https://github.com/torvalds/linux/blob/master/Documentation/networking/ip-sysctl.rst
The max value from conf/{all,interface}/arp_ignore is used when ARP request is received on the {interface}
arp_ignore will take the max value, therefore all interfaces will use the global value.
If this setting could be changed to be controlled via the interface, it would provide users with more flexibility.
Therefore, remove the global value and change the default arp_ignore setting of 2 to be configured per interface.
Related PR: sonic-net/sonic-swss#3122
Why I did it
arp_ignore has different modes for sending replies in response to received ARP requests that resolve the local target IP address.
Due to the strict settings of the arp_ignore global configuration, there are more restrictions.
Work item tracking
support a new field that allows dynamic modification of arp_ignore for different interfaces.
sonic-net/sonic-swss#3122
How I did it
Change global arp ignore level from "check ip within same subnet" to "all reply".
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)