-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GNMI client cert cname check support. #18709
Merged
qiluo-msft
merged 14 commits into
sonic-net:master
from
liuh-80:dev/liuh/add_gnmi_cert_cname
Aug 22, 2024
Merged
Add GNMI client cert cname check support. #18709
qiluo-msft
merged 14 commits into
sonic-net:master
from
liuh-80:dev/liuh/add_gnmi_cert_cname
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule PR: sonic-net/sonic-gnmi#241 |
/azpw Azure.sonic-buildimage |
liuh-80
changed the title
[POC] Add GNMI client cert cname list to yang model
[POC] Add GNMI client cert cname check support.
May 30, 2024
This was referenced Jun 5, 2024
liuh-80
changed the title
[POC] Add GNMI client cert cname check support.
Add GNMI client cert cname check support.
Jun 18, 2024
/azpw Azure.sonic-buildimage |
ganglyu
reviewed
Jul 2, 2024
ganglyu
approved these changes
Jul 2, 2024
qiluo-msft
reviewed
Jul 15, 2024
qiluo-msft
approved these changes
Jul 16, 2024
/azpw ms_conflict |
/azpw Azure.sonic-buildimage |
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
Add GNMI client cert cname list to yang model. #### Why I did it Allow gnmi service authentication client cert by cname. ### How I did it Add GNMI client cert cname list to yang model. #### How to verify it Pass all UT. ### Description for the changelog Add GNMI client cert cname list to yang model.
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
Nov 8, 2024
Add GNMI client cert cname list to yang model. #### Why I did it Allow gnmi service authentication client cert by cname. ### How I did it Add GNMI client cert cname list to yang model. #### How to verify it Pass all UT. ### Description for the changelog Add GNMI client cert cname list to yang model.
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
Nov 8, 2024
Add GNMI client cert cname list to yang model. #### Why I did it Allow gnmi service authentication client cert by cname. ### How I did it Add GNMI client cert cname list to yang model. #### How to verify it Pass all UT. ### Description for the changelog Add GNMI client cert cname list to yang model.
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
Nov 14, 2024
Add GNMI client cert cname list to yang model. #### Why I did it Allow gnmi service authentication client cert by cname. ### How I did it Add GNMI client cert cname list to yang model. #### How to verify it Pass all UT. ### Description for the changelog Add GNMI client cert cname list to yang model.
9 tasks
Manually cherry-pick not found conflict: #20792 |
Here is test case PR, also need cherry-pick later: sonic-net/sonic-mgmt#13133 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 14, 2024
Add GNMI client cert cname list to yang model. #### Why I did it Allow gnmi service authentication client cert by cname. ### How I did it Add GNMI client cert cname list to yang model. #### How to verify it Pass all UT. ### Description for the changelog Add GNMI client cert cname list to yang model.
Cherry-pick PR to 202405: #20793 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 14, 2024
Add GNMI client cert cname list to yang model. #### Why I did it Allow gnmi service authentication client cert by cname. ### How I did it Add GNMI client cert cname list to yang model. #### How to verify it Pass all UT. ### Description for the changelog Add GNMI client cert cname list to yang model.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Nov 14, 2024
yxieca
pushed a commit
that referenced
this pull request
Nov 15, 2024
Add GNMI client cert cname list to yang model. #### Why I did it Allow gnmi service authentication client cert by cname. ### How I did it Add GNMI client cert cname list to yang model. #### How to verify it Pass all UT. ### Description for the changelog Add GNMI client cert cname list to yang model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GNMI client cert cname list to yang model.
Why I did it
Allow gnmi service authentication client cert by cname.
Work item tracking
How I did it
Add GNMI client cert cname list to yang model.
How to verify it
Pass all UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
will updated with this PR image later.
Description for the changelog
Add GNMI client cert cname list to yang model.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)