Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNMI client cert cname check support. #18709

Merged
merged 14 commits into from
Aug 22, 2024

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Apr 18, 2024

Add GNMI client cert cname list to yang model.

Why I did it

Allow gnmi service authentication client cert by cname.

Work item tracking
  • Microsoft ADO: 25226269

How I did it

Add GNMI client cert cname list to yang model.

How to verify it

Pass all UT.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

will updated with this PR image later.

  • [] SONiC.master-16482.360728-2c8b4066f
  • [] SONiC.202405-20731.690016-d47b3771d
  • [] SONiC.202311-20734.692072-6612467e4

Description for the changelog

Add GNMI client cert cname list to yang model.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liuh-80
Copy link
Contributor Author

liuh-80 commented May 28, 2024

Submodule PR: sonic-net/sonic-gnmi#241

@liuh-80
Copy link
Contributor Author

liuh-80 commented May 28, 2024

/azpw Azure.sonic-buildimage

@liuh-80 liuh-80 changed the title [POC] Add GNMI client cert cname list to yang model [POC] Add GNMI client cert cname check support. May 30, 2024
@liuh-80 liuh-80 changed the title [POC] Add GNMI client cert cname check support. Add GNMI client cert cname check support. Jun 18, 2024
@liuh-80 liuh-80 closed this Jun 21, 2024
@liuh-80 liuh-80 reopened this Jun 21, 2024
@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 1, 2024

/azpw Azure.sonic-buildimage

@liuh-80 liuh-80 marked this pull request as ready for review July 2, 2024 02:23
@liuh-80 liuh-80 requested a review from ganglyu July 2, 2024 02:23
@qiluo-msft
Copy link
Collaborator

/azpw ms_conflict

@liuh-80
Copy link
Contributor Author

liuh-80 commented Aug 13, 2024

/azpw Azure.sonic-buildimage

@qiluo-msft qiluo-msft merged commit 106c38d into sonic-net:master Aug 22, 2024
22 checks passed
vvolam pushed a commit to vvolam/sonic-buildimage that referenced this pull request Sep 12, 2024
Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
liuh-80 added a commit to liuh-80/sonic-buildimage that referenced this pull request Nov 8, 2024
Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
liuh-80 added a commit to liuh-80/sonic-buildimage that referenced this pull request Nov 8, 2024
Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
liuh-80 added a commit to liuh-80/sonic-buildimage that referenced this pull request Nov 14, 2024
Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
@liuh-80
Copy link
Contributor Author

liuh-80 commented Nov 14, 2024

Manually cherry-pick not found conflict: #20792

@liuh-80
Copy link
Contributor Author

liuh-80 commented Nov 14, 2024

Here is test case PR, also need cherry-pick later: sonic-net/sonic-mgmt#13133

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 14, 2024
Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20793

mssonicbld pushed a commit that referenced this pull request Nov 14, 2024
Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
yxieca pushed a commit that referenced this pull request Nov 15, 2024
Add GNMI client cert cname list to yang model.

#### Why I did it
Allow gnmi service authentication client cert by cname.

### How I did it
Add GNMI client cert cname list to yang model.

#### How to verify it
Pass all UT.

### Description for the changelog
Add GNMI client cert cname list to yang model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants