Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hardware_checker] Check fan status immediately after fan presence st… #18547

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PJHsieh
Copy link

@PJHsieh PJHsieh commented Apr 3, 2024

…atus check

Description:
First, check the fan status. Then, verify the fan speed and other parameters. If the fan status is false, there's no need to proceed with the fan speed check.

Motivation and Context:
When the fan status is false, checking the fan speed and fan direction becomes irrelevant.

Why I did it

When the fan status is false, checking the fan speed and fan direction becomes irrelevant.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Check fan status immediately after fan presence status check

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…atus check

Description:
First, check the fan status. Then, verify the fan speed and
other parameters. If the fan status is false, there's no need
to proceed with the fan speed check.

Motivation and Context:
When the fan status is false, checking the fan speed and fan
direction becomes irrelevant.
@PJHsieh PJHsieh requested a review from lguohan as a code owner April 3, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant