Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edgecore][AS4630-54PE/PDDF] Enhance sonic_platform feature #14361

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

roger530-ho
Copy link
Contributor

Why I did it

  1. Base on Adding PDDF common framework enhancements. #12863 to modify pddf-device.json and platform API.
  2. Add code to pass pytest.

How I did it

Add needed code to sonic_platform and driver.

How to verify it

  1. sonic-cli cmd:
    show platform {fan, temperature, firmware status, syseeprom, psustatus}
  2. sfputil cmd:
    show {presence, eeprom, lpmode}
  3. Verify function by sonic-mgmt tools:
    Test file path: /tests/platform_tests/api/
    Test items: test_chassis.py, test_component.py, test_fan_drawer.py, test_psu.py, test_thermal.py, test_sfp.py

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@roger530-ho roger530-ho requested a review from lguohan as a code owner March 21, 2023 01:10
@mssonicbld
Copy link
Collaborator

@StormLiangMS,@liushilongbuaa PR: #14361 is conflict with MS internal repo
Please complete the following PR by pushing fix commit to sonicbld/conflict_prefix/14361-fix
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9228993
Then comment "/azpw ms_conflict" to rerun PR checker.

@liushilongbuaa
Copy link
Contributor

@StormLiangMS,@liushilongbuaa PR: #14361 is conflict with MS internal repoPlease complete the following PR by pushing fix commit to sonicbld/conflict_prefix/14361-fixhttps://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9228993Then comment "/azpw ms_conflict" to rerun PR checker.

PR is too old. @ec-michael-shih please rebase the latest master branch.

ChrisKe1643 pushed a commit to ChrisKe1643/ec-sonic-buildimage that referenced this pull request Mar 25, 2024
…feature

sonic-net/sonic-buildimage#14361

Why I did it
Base on Adding PDDF common framework enhancements. #12863 to modify pddf-device.json and platform API.
Add code to pass pytest.

How I did it
Add needed code to sonic_platform and driver.

How to verify it
sonic-cli cmd:
show platform {fan, temperature, firmware status, syseeprom, psustatus}
sfputil cmd:
show {presence, eeprom, lpmode}
Verify function by sonic-mgmt tools:
Test file path: /tests/platform_tests/api/
 Test items: test_chassis.py, test_component.py, test_fan_drawer.py, test_psu.py, test_thermal.py, test_sfp.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants