Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the SAI patch to fix the header file not found issue #13699

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Feb 7, 2023

Why I did it

It is to fix the build broken issue.
https://dev.azure.com/mssonic/build/_build/results?buildId=213554&view=logs&j=88ce9a53-729c-5fa9-7b6e-3d98f2488e3f&t=8d99be27-49d0-54d0-99b1-cfc0d47f0318

./checkenumlock.sh
Updated 52 paths from 0ce4bac
Checking for possible enum values shift (current branch vs origin/master) ...
In file included from ./temp/inc//sai.h:48,
                 from /tmp/DSPbFJGuPa.c:2:
./temp/inc//saiobject.h:40:10: fatal error: saiexperimentaldashvip.h: No such file or directory
   40 | #include <saiexperimentaldashvip.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Uncaught exception from user code:
	gcc failed! Inappropriate ioctl for device at ./checkheaders.pl line 152.
	main::GetValues("temp/inc/") called at ./checkheaders.pl line 172

How I did it

Apply the SAI patch to fix the header file not found issue, see opencomputeproject/SAI#1727 (comment)
The PR can be removed when the patch of the sai that has updated in sonic-sairedis.
The applied SAI patch is not in the same folder of the source folder, we need to apply the patch by a command in Makefile.

How to verify it

make SONIC_BUILD_JOBS=4 target/debs/bullseye/libsaithriftv2-dev_0.9.4_amd64.deb ENABLE_SYNCD_RPC=y SAITHRIFT_V2=y

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

prsunny
prsunny previously approved these changes Feb 8, 2023
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xumia xumia marked this pull request as draft February 11, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants