Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Celestica]Silverstone x commit master #11992

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

skannan-sonic
Copy link
Contributor

@skannan-sonic skannan-sonic commented Sep 7, 2022

Why I did it

Silverstone-X Support in master branch

How I did it

Silverstone-X support from pull request #11591
Marvell support only in 202111 so pull from 202111 #10760
Wistron support only in 202111 so pull from 202111 #11818

How to verify it

sfputil show eeprom | pass
sfputil show presence | pass
sfputil show lpmode | pass
psuutil status | pass
psuutil numpsus | Pass - Reports 2
show platform psustatus | pass- output matches psuutil status
show platform fan | pass
show platform firmware status | pass
show platform firmware updates | pass,
show platform summary | pass
show platform syseeprom | pass
show reboot-cause | pass
show version | pass
show environment | pass
PMON running | PMON ok (error in thermal status seen in 201911 too)

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2022

This pull request introduces 10 alerts and fixes 8 when merging 5d48ff6 into 38cc35f - view on LGTM.com

new alerts:

  • 4 for 'import *' may pollute namespace
  • 1 for Module imports itself
  • 1 for Unused local variable
  • 1 for Except block handles 'BaseException'
  • 1 for Unused import
  • 1 for Wrong name for an argument in a class instantiation
  • 1 for Wrong number of arguments in a class instantiation

fixed alerts:

  • 8 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request introduces 10 alerts and fixes 8 when merging 464228e into 549bb3d - view on LGTM.com

new alerts:

  • 4 for 'import *' may pollute namespace
  • 1 for Module imports itself
  • 1 for Unused local variable
  • 1 for Except block handles 'BaseException'
  • 1 for Unused import
  • 1 for Wrong name for an argument in a class instantiation
  • 1 for Wrong number of arguments in a class instantiation

fixed alerts:

  • 8 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Sep 12, 2022

This pull request introduces 2 alerts and fixes 8 when merging 7d7b569 into c53972b - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a class instantiation

fixed alerts:

  • 8 for Wrong number of arguments in a class instantiation

@lguohan lguohan added the device label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants