Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctrmgrd unexpectedly restart service issue #11037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kuanyu99
Copy link
Contributor

@kuanyu99 kuanyu99 commented Jun 6, 2022

Why I did it

During our test time, we run config reload and reboot for multiple times. We found occasionally the ctrmgrd.py will restart some features(services) and that will disturb the system status.

How I did it

Prevent the ctrmgrd.py to restart the services when the owner is setting a new value from "none". Which is a default value setting by container script when docker stop.

How to verify it

Run the same test for few days and make sure the following type syslog will not occur.

May 14 07:41:58.653540 admin DEBUG ctrmgrd.py: restart_systemd_service: Restart service syncd to owner:local

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

If the state_db has any docker stop setting which will set the current_owner to none, the ctrmgrd will then restart the service when it receive config_db change.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

* If the state_db has any docker stop setting which will
  set the current_owner to none, the ctrmgrd will then restart
  the service when it receive config_db change
@kuanyu99 kuanyu99 requested a review from lguohan as a code owner June 6, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant