[AVM CI Environment Issue]: Pester static tests for managedIdentitiesType are skipped

[peterbud]

Check for previous/existing GitHub issues

• I have checked for previous/existing GitHub issues

Issue Type?

Bug

Description

I have noticed that Pester static tests for managedIdentitiesType are skipped in the CI runs, as I believe the type has been recently renamed to managedIdentitiesAllType.

Example from a recent CI run:
Module tests / Template tests / Parameters / Schema-based User-defined-types tests / [sql/server] If a UDT definition [managedIdentitiesType] exists and supports system-assigned-identities, the template should have an output for its principal ID. |

Test is skipped, because because the module template has no [managedIdentitiesType] UDT definition or does not support system-assigned-identities.

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[AlexanderSehr]

Hey @peterbud,
Very observant 💪
With the introduction of the avm-common-types we had to refactor the current tests to allow for references instead of local implementations and this may have fallen through the cracks.
That being said, there are plans to introduce a new set of tests for these types (for one, regarding the implementation + their version) but we should fix this regardless.

That being said, regarding the specific test in question it should be noted that it should only fire if the resource supports system assigned identities. We hence need to find a better/new way to detect this case.

cc: @eriqua (if you want to add anything 🙂)

Will remove the triage label. And we can work on this once a PR moving the utilities folder was merged (to avoid conflicts)