Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kusto C# SDK For Managment- 2024-04-13 #47564

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

guyhirPublic
Copy link
Member

@guyhirPublic guyhirPublic commented Dec 15, 2024

Pls make sure not to release the new package before the 16th of January 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 15, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Kusto

@guyhirPublic guyhirPublic changed the title User/t guyhirsch/kusto update c# sdk Kusto C# SDK For Managment- 2024-04-13 Dec 15, 2024
@guyhirPublic guyhirPublic marked this pull request as ready for review December 15, 2024 11:47
@@ -1,5 +1,18 @@
# Release History

## 1.6.0 (2025-01-16)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I got this error for this date:
"Build log #L44

Invalid date [ 2025-01-16 ]. The date for the changelog being released must be the latest in the file."

Can you help me with this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guyhirPublic You need to remove ## 1.6.0-beta.1 (Unreleased) below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I keep the content or remove it all? @archerzz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I keep the content or remove it all? @archerzz

Since 1.6.0-beta.1 is never released, you need to check the contents and merge them into 1.6.0 if necessary.

@guyhirPublic
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guyhirPublic :

Your account lacks the required public membership to the Azure GitHub organization needed for an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@@ -1,5 +1,18 @@
# Release History

## 1.6.0 (2025-01-16)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guyhirPublic You need to remove ## 1.6.0-beta.1 (Unreleased) below

@jsquire jsquire dismissed their stale review December 16, 2024 18:00

Account issues confirmed resolved.

@archerzz
Copy link
Member

@guyhirPublic There are some cspell errors. Please check https://dev.azure.com/azure-sdk/public/_build/results?buildId=4413923&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f&l=140

CSpell: Files checked: 3, Issues found: 2 in 2 files
cspell run complete, restoring original configuration and removing temp file.
./sdk/kusto/Azure.ResourceManager.Kusto/api/Azure.ResourceManager.Kusto.net8.0.cs:903:75 - Unknown word (Openai)
./sdk/kusto/Azure.ResourceManager.Kusto/api/Azure.ResourceManager.Kusto.netstandard2.0.cs:903:75 - Unknown word (Openai)
##[error]Spelling errors detected. To correct false positives or learn about spell checking see: https://aka.ms/azsdk/engsys/spellcheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants