Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorder] Use import over require for the dependencies #7033

Closed
HarshaNalluru opened this issue Jan 20, 2020 · 1 comment
Closed

[Recorder] Use import over require for the dependencies #7033

HarshaNalluru opened this issue Jan 20, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Jan 20, 2020

In the recorder, to import some of the modules like nock or path, we depend on require and conditionally serve whenever needed and avoid import statements in order not to fail in the browsers.

We can handle this better by

  • separating out the node and browser code
  • use import instead of require
  • with proper shimming through rollup
  • and tree-shaking with rollup
@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder labels Jan 20, 2020
@HarshaNalluru HarshaNalluru self-assigned this Jan 20, 2020
@HarshaNalluru HarshaNalluru changed the title [Recorder] Separate browser src code and node src code to fix rollup warnings [Recorder] Separate browser src code and node src code to use import over require Jan 21, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] February milestone Jan 21, 2020
@HarshaNalluru HarshaNalluru changed the title [Recorder] Separate browser src code and node src code to use import over require [Recorder] Use import over require Jan 21, 2020
@HarshaNalluru HarshaNalluru changed the title [Recorder] Use import over require [Recorder] Use import over require for the dependencies Jan 21, 2020
@HarshaNalluru HarshaNalluru removed their assignment Apr 10, 2020
Copy link

Hi @HarshaNalluru, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Development

No branches or pull requests

3 participants