-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable drop counters HLD #434
Conversation
It might make sense to specifically separate SAI requirement v.s. SONiC requirement. Though most of the requirements are SONiC requirements. |
"SWITCH_INGRESS_DROPS": { | ||
"total": 3, | ||
"used": 1, | ||
"reasons": [L2_ANY, L3_ANY, SMAC_EQUALS_DMAC] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the scope of L2_ANY drop reason? is this specific hardware platform? what are the SONiC platforms supported this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L2_ANY refers to any drop reason coming from layer 2, so for example if a frame has the same source mac and destination mac, if a frame is larger than the MTU, etc. Any packet dropped due to problems at layer 2 will be counted under L2_ANY.
L2_ANY is defined in the SAI so in theory it should not be platform specific. That being said, I don't think any of the platforms support this drop reason yet except for maybe Mellanox (let me get back to you on that!)
This document describes the high level design details for configurable packet drop counters in SONiC.
Signed-off-by: Danny Allen [email protected]