Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync from noir #9332

Merged
merged 20 commits into from
Oct 23, 2024
Merged

feat: Sync from noir #9332

merged 20 commits into from
Oct 23, 2024

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Oct 22, 2024 •
edited
Loading

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat(ssa): Various mem2reg reverts to reduce memory and compilation time (noir-lang/noir#6307)
chore: update noir-edwards repo to point at noir-lang org (noir-lang/noir#6323)
feat: Sha256 refactoring and benchmark with longer input (noir-lang/noir#6318)
chore: Release Noir(0.36.0) (noir-lang/noir#6213)
chore: remove usage of slices in pedersen hash (noir-lang/noir#6295)
chore: remove dead function (noir-lang/noir#6308)
feat: new formatter (noir-lang/noir#6300)
feat: Sync from aztec-packages (noir-lang/noir#6301)
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
END_COMMIT_OVERRIDE

AztecBot and others added 7 commits October 22, 2024 13:11
@AztecBot
[1 changes] feat: Sync from aztec-packages (noir-lang/noir#6301)
e5c7c51 
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
@AztecBot
chore: apply sync fixes
697b72c
@AztecBot
[1 changes] feat: new formatter (noir-lang/noir#6300)
8d9a52c 
feat: Sync from aztec-packages (noir-lang/noir#6301)
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
@AztecBot
chore: apply sync fixes
1fe1516
@AztecBot
feat: new formatter (noir-lang/noir#6300)
e0ead20 
feat: Sync from aztec-packages (noir-lang/noir#6301)
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
@TomAFrench
.
8dc13d9
@TomAFrench
chore: format
05e1310
@TomAFrench
Merge branch 'master' into sync-noir
2e1ca53 
* master: (26 commits)
  chore: silence cache-download.sh (#9317)
  feat: apella (#9084)
  feat: gerousia (#8942)
  fix: use github.actor on publish workflow dispatch (#9324)
  chore: Copying world state binary to yarn project is on generate (#9194)
  feat: modify private calldata to use public keys (#9276)
  chore: test 4epochs in native-network (#9309)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix: ci github clone edge case (#9320)
  feat: Handle reorgs on sequencer (#9201)
  chore(avm): some cleaning in avm prover (#9311)
  fix: barretenberg readme scare warning (#9313)
  feat: Constrain protocol VK hashing (#9304)
  chore(master): Release 0.59.0 (#9281)
  fix: publish readme on bb.js NPM package (#9303)
  chore: re-enable test fixed by Native World State (#9289)
  fix(docs): Dapp tutorial edits (#8695)
  ...
@TomAFrench
.
bc99f15
@TomAFrench TomAFrench enabled auto-merge (squash) October 22, 2024 13:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

Changes to public function bytecode sizes

Generated at commit: 7306dcf2c8dd6a7499b5b7d6d5423780bd7c9b9d, compared to commit: c8e4260efdd7f8a24b189800dcacedeb5e257562

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::set_read_storage_single +49 ❌ +8.55%
EasyPrivateVoting::end_vote +49 ❌ +7.97%
NFT::set_admin +49 ❌ +7.95%
Token::set_admin +49 ❌ +7.95%
Child::pub_inc_value +49 ❌ +7.54%
StaticChild::pub_inc_value +49 ❌ +7.54%
AvmTest::elliptic_curve_add +37 ❌ +7.52%
StaticChild::pub_illegal_inc_value +49 ❌ +7.31%
Child::pub_inc_value_internal +49 ❌ +7.26%
NFT::set_minter +125 ❌ +6.83%
StatefulTest::increment_public_value_no_init_check +120 ❌ +6.78%
StatefulTest::increment_public_value +120 ❌ +6.67%
Token::mint_private +196 ❌ +6.63%
Token::set_minter +120 ❌ +6.55%
DocsExample::initialize_public_immutable +49 ❌ +6.49%
DocsExample::initialize_shared_immutable +49 ❌ +6.49%
AvmTest::add_storage_map +125 ❌ +6.35%
Child::set_value_twice_with_nested_last +54 ❌ +6.21%
Child::set_value_twice_with_nested_first +54 ❌ +6.21%
AvmTest::elliptic_curve_add_and_double +37 ❌ +5.98%
Token::_reduce_total_supply +49 ❌ +5.59%
PrivateFPC::constructor +192 ❌ +5.47%
AvmTest::poseidon2_hash +81 ❌ +5.43%
AvmTest::get_args_hash +81 ❌ +5.17%
AuthRegistry::set_reject_all +81 ❌ +5.15%
TokenBlacklist::_reduce_total_supply +44 ❌ +5.02%
NFT::_finish_transfer_to_public +81 ❌ +5.02%
Auth::get_scheduled_authorized +81 ❌ +4.91%
PriceFeed::set_price +81 ❌ +4.90%
AvmTest::read_storage_map +81 ❌ +4.89%
StatefulTest::get_public_value +81 ❌ +4.86%
AuthRegistry::is_reject_all +81 ❌ +4.84%
AvmTest::set_storage_map +81 ❌ +4.83%
PriceFeed::get_price +81 ❌ +4.78%
TokenBlacklist::mint_private +179 ❌ +4.76%
Benchmarking::broadcast +81 ❌ +4.75%
NFT::is_minter +81 ❌ +4.74%
Token::is_minter +81 ❌ +4.74%
AuthRegistry::set_authorized +81 ❌ +4.69%
Auth::get_authorized +81 ❌ +4.65%
AuthRegistry::_set_authorized +81 ❌ +4.62%
FeeJuice::balance_of_public +81 ❌ +4.62%
TokenBlacklist::balance_of_public +81 ❌ +4.54%
Token::balance_of_public +81 ❌ +4.54%
PrivateFPC::public_dispatch +200 ❌ +4.53%
InclusionProofs::constructor +137 ❌ +4.45%
AuthRegistry::is_consumable +81 ❌ +4.42%
InclusionProofs::public_dispatch +197 ❌ +4.40%
Lending::get_asset +81 ❌ +4.28%
CardGame::on_card_played +215 ❌ +4.24%
TokenBridge::constructor +148 ❌ +4.05%
Claim::constructor +148 ❌ +4.03%
CardGame::on_game_joined +173 ❌ +4.00%
Auth::get_authorized_delay +81 ❌ +3.96%
FeeJuice::check_balance +81 ❌ +3.92%
Parent::public_nested_static_call +125 ❌ +3.80%
EasyPrivateVoting::add_to_tally_public +81 ❌ +3.71%
StatefulTest::public_constructor +142 ❌ +3.71%
Lending::_deposit +81 ❌ +3.67%
Token::assert_minter_and_mint +81 ❌ +3.66%
FeeJuice::_increase_public_balance +81 ❌ +3.61%
PriceFeed::public_dispatch +123 ❌ +3.49%
Claim::public_dispatch +156 ❌ +3.40%
NFT::owner_of +81 ❌ +3.37%
Spam::public_spam +81 ❌ +3.34%
Token::complete_refund +91 ❌ +3.33%
TokenBlacklist::_increase_public_balance +81 ❌ +3.29%
Token::_increase_public_balance +81 ❌ +3.29%
AvmInitializerTest::constructor +98 ❌ +3.23%
NFT::transfer_in_public +108 ❌ +3.06%
Lending::init +81 ❌ +2.92%
AvmTest::test_get_contract_instance +34 ❌ +2.91%
Token::shield +140 ❌ +2.84%
FPC::constructor +98 ❌ +2.79%
Uniswap::constructor +98 ❌ +2.79%
Benchmarking::increment_balance +81 ❌ +2.78%
Auth::constructor +98 ❌ +2.78%
NFT::mint +81 ❌ +2.77%
EasyPrivateVoting::constructor +98 ❌ +2.67%
CardGame::start_game +162 ❌ +2.66%
Spam::public_dispatch +89 ❌ +2.66%
TokenBlacklist::get_roles +64 ❌ +2.63%
Token::mint_public +81 ❌ +2.61%
AvmInitializerTest::public_dispatch +98 ❌ +2.61%
TokenBlacklist::shield +157 ❌ +2.61%
Benchmarking::public_dispatch +123 ❌ +2.60%
StatefulTest::public_dispatch +192 ❌ +2.49%
Crowdfunding::init +98 ❌ +2.47%
AppSubscription::constructor +98 ❌ +2.38%
EasyPrivateVoting::public_dispatch +148 ❌ +2.37%
Lending::update_accumulator +120 ❌ +2.35%
AuthRegistry::consume +64 ❌ +2.25%
ImportTest::public_dispatch +34 ❌ +2.09%
AppSubscription::public_dispatch +106 ❌ +1.98%
NFT::constructor +98 ❌ +1.92%
TestLog::public_dispatch +55 ❌ +1.86%
Token::constructor +98 ❌ +1.80%
Crowdfunding::public_dispatch +114 ❌ +1.79%
Lending::get_position +81 ❌ +1.75%
FeeJuice::public_dispatch +97 ❌ +1.73%
Parent::public_dispatch +131 ❌ +1.72%
FPC::public_dispatch +148 ❌ +1.62%
Lending::_repay +81 ❌ +1.59%
TokenBlacklist::mint_public +64 ❌ +1.56%
TokenBlacklist::burn_public +81 ❌ +1.46%
Token::burn_public +64 ❌ +1.43%
Token::transfer_public +64 ❌ +1.40%
TokenBlacklist::transfer_public +81 ❌ +1.36%
TokenBlacklist::constructor +98 ❌ +1.23%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 +64 ❌ +1.21%
Auth::set_authorized_delay +64 ❌ +1.20%
Auth::set_authorized +64 ❌ +1.18%
Lending::_borrow +81 ❌ +1.15%
AuthRegistry::public_dispatch +88 ❌ +1.15%
Lending::_withdraw +81 ❌ +1.15%
Token::public_dispatch +293 ❌ +1.08%
StaticParent::public_dispatch +58 ❌ +1.03%
NFT::public_dispatch +219 ❌ +1.03%
Auth::public_dispatch +106 ❌ +1.00%
TokenBlacklist::update_roles +64 ❌ +0.92%
CardGame::public_dispatch +131 ❌ +0.89%
TokenBlacklist::public_dispatch +202 ❌ +0.83%
Lending::public_dispatch +113 ❌ +0.46%
AuthWitTest::public_dispatch +8 ❌ +0.39%
DocsExample::public_dispatch +16 ❌ +0.32%
Router::public_dispatch +8 ❌ +0.29%
StaticChild::public_dispatch +8 ❌ +0.29%
TestLog::emit_unencrypted_events +4 ❌ +0.24%
Child::public_dispatch +8 ❌ +0.15%
NFT::finalize_transfer_to_private -9 ✅ -0.17%
AvmTest::public_dispatch -101 ✅ -0.19%
Uniswap::public_dispatch -47 ✅ -0.21%
CardGame::on_cards_claimed -26 ✅ -0.39%
TokenBridge::public_dispatch -198 ✅ -1.01%
AvmTest::bulk_testing -276 ✅ -1.15%
Uniswap::swap_public -161 ✅ -1.29%
Test::consume_message_from_arbitrary_sender_public -117 ✅ -1.80%
Test::consume_mint_public_message -192 ✅ -2.24%
TokenBridge::claim_public -241 ✅ -2.43%
Test::public_dispatch -440 ✅ -2.55%
TokenBridge::exit_to_l1_public -221 ✅ -3.28%
Test::create_l2_to_l1_message_public -140 ✅ -7.00%
AvmTest::sha256_hash -225 ✅ -7.68%
AvmTest::pedersen_hash -286 ✅ -9.45%
AvmTest::pedersen_hash_with_index -286 ✅ -9.45%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::set_read_storage_single 622 (+49) +8.55%
EasyPrivateVoting::end_vote 664 (+49) +7.97%
NFT::set_admin 665 (+49) +7.95%
Token::set_admin 665 (+49) +7.95%
Child::pub_inc_value 699 (+49) +7.54%
StaticChild::pub_inc_value 699 (+49) +7.54%
AvmTest::elliptic_curve_add 529 (+37) +7.52%
StaticChild::pub_illegal_inc_value 719 (+49) +7.31%
Child::pub_inc_value_internal 724 (+49) +7.26%
NFT::set_minter 1,956 (+125) +6.83%
StatefulTest::increment_public_value_no_init_check 1,891 (+120) +6.78%
StatefulTest::increment_public_value 1,919 (+120) +6.67%
Token::mint_private 3,154 (+196) +6.63%
Token::set_minter 1,951 (+120) +6.55%
DocsExample::initialize_public_immutable 804 (+49) +6.49%
DocsExample::initialize_shared_immutable 804 (+49) +6.49%
AvmTest::add_storage_map 2,095 (+125) +6.35%
Child::set_value_twice_with_nested_last 924 (+54) +6.21%
Child::set_value_twice_with_nested_first 924 (+54) +6.21%
AvmTest::elliptic_curve_add_and_double 656 (+37) +5.98%
Token::_reduce_total_supply 926 (+49) +5.59%
PrivateFPC::constructor 3,700 (+192) +5.47%
AvmTest::poseidon2_hash 1,573 (+81) +5.43%
AvmTest::get_args_hash 1,647 (+81) +5.17%
AuthRegistry::set_reject_all 1,654 (+81) +5.15%
TokenBlacklist::_reduce_total_supply 921 (+44) +5.02%
NFT::_finish_transfer_to_public 1,696 (+81) +5.02%
Auth::get_scheduled_authorized 1,731 (+81) +4.91%
PriceFeed::set_price 1,734 (+81) +4.90%
AvmTest::read_storage_map 1,736 (+81) +4.89%
StatefulTest::get_public_value 1,746 (+81) +4.86%
AuthRegistry::is_reject_all 1,756 (+81) +4.84%
AvmTest::set_storage_map 1,759 (+81) +4.83%
PriceFeed::get_price 1,774 (+81) +4.78%
TokenBlacklist::mint_private 3,940 (+179) +4.76%
Benchmarking::broadcast 1,787 (+81) +4.75%
NFT::is_minter 1,789 (+81) +4.74%
Token::is_minter 1,789 (+81) +4.74%
AuthRegistry::set_authorized 1,807 (+81) +4.69%
Auth::get_authorized 1,823 (+81) +4.65%
AuthRegistry::_set_authorized 1,833 (+81) +4.62%
FeeJuice::balance_of_public 1,833 (+81) +4.62%
TokenBlacklist::balance_of_public 1,866 (+81) +4.54%
Token::balance_of_public 1,866 (+81) +4.54%
PrivateFPC::public_dispatch 4,617 (+200) +4.53%
InclusionProofs::constructor 3,217 (+137) +4.45%
AuthRegistry::is_consumable 1,914 (+81) +4.42%
InclusionProofs::public_dispatch 4,673 (+197) +4.40%
Lending::get_asset 1,974 (+81) +4.28%
CardGame::on_card_played 5,285 (+215) +4.24%
TokenBridge::constructor 3,798 (+148) +4.05%
Claim::constructor 3,819 (+148) +4.03%
CardGame::on_game_joined 4,495 (+173) +4.00%
Auth::get_authorized_delay 2,127 (+81) +3.96%
FeeJuice::check_balance 2,149 (+81) +3.92%
Parent::public_nested_static_call 3,412 (+125) +3.80%
EasyPrivateVoting::add_to_tally_public 2,265 (+81) +3.71%
StatefulTest::public_constructor 3,974 (+142) +3.71%
Lending::_deposit 2,290 (+81) +3.67%
Token::assert_minter_and_mint 2,296 (+81) +3.66%
FeeJuice::_increase_public_balance 2,322 (+81) +3.61%
PriceFeed::public_dispatch 3,651 (+123) +3.49%
Claim::public_dispatch 4,741 (+156) +3.40%
NFT::owner_of 2,482 (+81) +3.37%
Spam::public_spam 2,503 (+81) +3.34%
Token::complete_refund 2,820 (+91) +3.33%
TokenBlacklist::_increase_public_balance 2,541 (+81) +3.29%
Token::_increase_public_balance 2,541 (+81) +3.29%
AvmInitializerTest::constructor 3,128 (+98) +3.23%
NFT::transfer_in_public 3,639 (+108) +3.06%
Lending::init 2,855 (+81) +2.92%
AvmTest::test_get_contract_instance 1,202 (+34) +2.91%
Token::shield 5,075 (+140) +2.84%
FPC::constructor 3,609 (+98) +2.79%
Uniswap::constructor 3,609 (+98) +2.79%
Benchmarking::increment_balance 2,993 (+81) +2.78%
Auth::constructor 3,629 (+98) +2.78%
NFT::mint 3,001 (+81) +2.77%
EasyPrivateVoting::constructor 3,772 (+98) +2.67%
CardGame::start_game 6,248 (+162) +2.66%
Spam::public_dispatch 3,436 (+89) +2.66%
TokenBlacklist::get_roles 2,494 (+64) +2.63%
Token::mint_public 3,179 (+81) +2.61%
AvmInitializerTest::public_dispatch 3,854 (+98) +2.61%
TokenBlacklist::shield 6,175 (+157) +2.61%
Benchmarking::public_dispatch 4,846 (+123) +2.60%
StatefulTest::public_dispatch 7,913 (+192) +2.49%
Crowdfunding::init 4,064 (+98) +2.47%
AppSubscription::constructor 4,211 (+98) +2.38%
EasyPrivateVoting::public_dispatch 6,399 (+148) +2.37%
Lending::update_accumulator 5,235 (+120) +2.35%
AuthRegistry::consume 2,913 (+64) +2.25%
ImportTest::public_dispatch 1,661 (+34) +2.09%
AppSubscription::public_dispatch 5,469 (+106) +1.98%
NFT::constructor 5,211 (+98) +1.92%
TestLog::public_dispatch 3,008 (+55) +1.86%
Token::constructor 5,554 (+98) +1.80%
Crowdfunding::public_dispatch 6,498 (+114) +1.79%
Lending::get_position 4,718 (+81) +1.75%
FeeJuice::public_dispatch 5,701 (+97) +1.73%
Parent::public_dispatch 7,757 (+131) +1.72%
FPC::public_dispatch 9,269 (+148) +1.62%
Lending::_repay 5,189 (+81) +1.59%
TokenBlacklist::mint_public 4,178 (+64) +1.56%
TokenBlacklist::burn_public 5,634 (+81) +1.46%
Token::burn_public 4,539 (+64) +1.43%
Token::transfer_public 4,646 (+64) +1.40%
TokenBlacklist::transfer_public 6,036 (+81) +1.36%
TokenBlacklist::constructor 8,082 (+98) +1.23%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 5,353 (+64) +1.21%
Auth::set_authorized_delay 5,413 (+64) +1.20%
Auth::set_authorized 5,493 (+64) +1.18%
Lending::_borrow 7,094 (+81) +1.15%
AuthRegistry::public_dispatch 7,745 (+88) +1.15%
Lending::_withdraw 7,150 (+81) +1.15%
Token::public_dispatch 27,547 (+293) +1.08%
StaticParent::public_dispatch 5,670 (+58) +1.03%
NFT::public_dispatch 21,528 (+219) +1.03%
Auth::public_dispatch 10,719 (+106) +1.00%
TokenBlacklist::update_roles 7,014 (+64) +0.92%
CardGame::public_dispatch 14,790 (+131) +0.89%
TokenBlacklist::public_dispatch 24,585 (+202) +0.83%
Lending::public_dispatch 24,617 (+113) +0.46%
AuthWitTest::public_dispatch 2,042 (+8) +0.39%
DocsExample::public_dispatch 5,019 (+16) +0.32%
Router::public_dispatch 2,727 (+8) +0.29%
StaticChild::public_dispatch 2,771 (+8) +0.29%
TestLog::emit_unencrypted_events 1,684 (+4) +0.24%
Child::public_dispatch 5,391 (+8) +0.15%
NFT::finalize_transfer_to_private 5,227 (-9) -0.17%
AvmTest::public_dispatch 53,999 (-101) -0.19%
Uniswap::public_dispatch 22,037 (-47) -0.21%
CardGame::on_cards_claimed 6,650 (-26) -0.39%
TokenBridge::public_dispatch 19,488 (-198) -1.01%
AvmTest::bulk_testing 23,718 (-276) -1.15%
Uniswap::swap_public 12,354 (-161) -1.29%
Test::consume_message_from_arbitrary_sender_public 6,374 (-117) -1.80%
Test::consume_mint_public_message 8,361 (-192) -2.24%
TokenBridge::claim_public 9,658 (-241) -2.43%
Test::public_dispatch 16,788 (-440) -2.55%
TokenBridge::exit_to_l1_public 6,517 (-221) -3.28%
Test::create_l2_to_l1_message_public 1,860 (-140) -7.00%
AvmTest::sha256_hash 2,704 (-225) -7.68%
AvmTest::pedersen_hash 2,740 (-286) -9.45%
AvmTest::pedersen_hash_with_index 2,740 (-286) -9.45%

AztecBot and others added 9 commits October 23, 2024 08:02
@AztecBot
[1 changes] chore: remove usage of slices in pedersen hash (noir-lang…
06768d9 
…/noir#6295)

chore: remove dead function (noir-lang/noir#6308)
feat: new formatter (noir-lang/noir#6300)
feat: Sync from aztec-packages (noir-lang/noir#6301)
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
@AztecBot
chore: apply sync fixes
04de75f
@AztecBot
chore: remove usage of slices in pedersen hash (noir-lang/noir#6295)
cbfbd84 
chore: remove dead function (noir-lang/noir#6308)
feat: new formatter (noir-lang/noir#6300)
feat: Sync from aztec-packages (noir-lang/noir#6301)
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
@AztecBot
[1 changes] feat(ssa): Various mem2reg reverts to reduce memory and c…
3b8ad85 
…ompilation time (noir-lang/noir#6307)

chore: update `noir-edwards` repo to point at `noir-lang` org (noir-lang/noir#6323)
feat: Sha256 refactoring and benchmark with longer input (noir-lang/noir#6318)
chore: Release Noir(0.36.0) (noir-lang/noir#6213)
chore: remove usage of slices in pedersen hash (noir-lang/noir#6295)
chore: remove dead function (noir-lang/noir#6308)
feat: new formatter (noir-lang/noir#6300)
feat: Sync from aztec-packages (noir-lang/noir#6301)
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
@AztecBot
chore: apply sync fixes
b6335a3
@AztecBot
feat(ssa): Various mem2reg reverts to reduce memory and compilation t…
f0ad605 
…ime (noir-lang/noir#6307)

chore: update `noir-edwards` repo to point at `noir-lang` org (noir-lang/noir#6323)
feat: Sha256 refactoring and benchmark with longer input (noir-lang/noir#6318)
chore: Release Noir(0.36.0) (noir-lang/noir#6213)
chore: remove usage of slices in pedersen hash (noir-lang/noir#6295)
chore: remove dead function (noir-lang/noir#6308)
feat: new formatter (noir-lang/noir#6300)
feat: Sync from aztec-packages (noir-lang/noir#6301)
fix: Allow array map on empty arrays (noir-lang/noir#6305)
fix: Display function name and body when inlining recursion limit hit (noir-lang/noir#6291)
feat(interpreter): Comptime derive generators (noir-lang/noir#6303)
fix: enforce correctness of decompositions performed at compile time (noir-lang/noir#6278)
feat: Warn about private types leaking in public functions and struct fields (noir-lang/noir#6296)
chore(docs): refactoring guides and some other nits (noir-lang/noir#6175)
fix: Do not warn on unused self in traits (noir-lang/noir#6298)
fix: Reject invalid expression with in CLI parser (noir-lang/noir#6287)
@TomAFrench
Merge branch 'master' into sync-noir
3e182f1 
* master:
  fix: remove reliance on invalid decompositions in selector calculation (#9337)
  chore: disable bench-process-history (#9360)
  feat(avm): full poseidon2 (#9141)
  chore: remove noir_js_backend_barretenberg (#9338)
  feat!: TXE single execution env (#9183)
  fix(ci): report 4 epochs true  (#9346)
  feat: translator on Shplemini (#9329)
  fix: support empty epochs (#9341)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  refactor: minor test cleanup (#9339)
  feat!: remove hash opcodes from AVM (#9209)
  chore!: remove delegate call and storage address (#9330)
  feat: publicly accessible bootstrap cache (#9335)
  fix(avm): public dispatch in proving tests (#9331)
  test: scenario for upgrading gerousia (#9246)
@TomAFrench
.
4b49e9e
@TomAFrench
.
66598c1
@TomAFrench TomAFrench disabled auto-merge October 23, 2024 17:32
@TomAFrench TomAFrench closed this Oct 23, 2024
@TomAFrench TomAFrench reopened this Oct 23, 2024
@TomAFrench TomAFrench enabled auto-merge (squash) October 23, 2024 17:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Changes to circuit sizes

Generated at commit: 7306dcf2c8dd6a7499b5b7d6d5423780bd7c9b9d, compared to commit: c8e4260efdd7f8a24b189800dcacedeb5e257562

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_inner +206 ❌ +0.08% +240 ❌ +0.05%
rollup_block_merge -129 ✅ -1.69% -66 ✅ -0.00%
rollup_root -129 ✅ -1.69% -66 ✅ -0.00%
rollup_block_root -258 ✅ -5.42% -132 ✅ -0.00%
parity_root -387 ✅ -6.34% -198 ✅ -0.01%
rollup_merge -258 ✅ -6.24% -131 ✅ -0.01%
rollup_base -4,515 ✅ -0.93% -2,722 ✅ -0.08%
parity_base -387 ✅ -7.21% -198 ✅ -0.61%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_inner 264,492 (+206) +0.08% 509,011 (+240) +0.05%
rollup_block_merge 7,499 (-129) -1.69% 1,907,273 (-66) -0.00%
rollup_root 7,483 (-129) -1.69% 1,907,259 (-66) -0.00%
rollup_block_root 4,502 (-258) -5.42% 2,848,957 (-132) -0.00%
parity_root 5,717 (-387) -6.34% 3,790,518 (-198) -0.01%
rollup_merge 3,876 (-258) -6.24% 1,904,039 (-131) -0.01%
rollup_base 478,886 (-4,515) -0.93% 3,356,970 (-2,722) -0.08%
parity_base 4,984 (-387) -7.21% 32,095 (-198) -0.61%

@TomAFrench TomAFrench merged commit a166203 into master Oct 23, 2024
56 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch October 23, 2024 18:33
TomAFrench added a commit that referenced this pull request Oct 23, 2024
@TomAFrench
Merge branch 'master' into sync-noir
fe12c0c 
* master: (45 commits)
  feat: Sync from noir (#9332)
  fix: remove reliance on invalid decompositions in selector calculation (#9337)
  chore: disable bench-process-history (#9360)
  feat(avm): full poseidon2 (#9141)
  chore: remove noir_js_backend_barretenberg (#9338)
  feat!: TXE single execution env (#9183)
  fix(ci): report 4 epochs true  (#9346)
  feat: translator on Shplemini (#9329)
  fix: support empty epochs (#9341)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  refactor: minor test cleanup (#9339)
  feat!: remove hash opcodes from AVM (#9209)
  chore!: remove delegate call and storage address (#9330)
  feat: publicly accessible bootstrap cache (#9335)
  fix(avm): public dispatch in proving tests (#9331)
  test: scenario for upgrading gerousia (#9246)
  chore: silence cache-download.sh (#9317)
  ...
@AztecBot AztecBot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

@fcarreiro fcarreiro Awaiting requested review from fcarreiro fcarreiro is a code owner

@dbanks12 dbanks12 Awaiting requested review from dbanks12 dbanks12 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AztecBot @TomAFrench