Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistencies on L2Block-logs #10522

Closed
FilipHarald opened this issue Dec 9, 2024 · 2 comments
Closed

inconsistencies on L2Block-logs #10522

FilipHarald opened this issue Dec 9, 2024 · 2 comments
Labels
from-community This originated from the community :) help wanted Extra attention is needed

Comments

@FilipHarald
Copy link
Contributor

With #10210 and/or #10308 the API on L2Block for getting logs changed. - I'm sure it's for good reasons, but with the current implementation there are now inconsistencies between the txEffect.privateLogs and txEffect.unencryptedLogs.

The former is an array, and the latter is an object (with the logs/array in .functionLogs).

@FilipHarald
Copy link
Contributor Author

Also, @LeilaWang and @rahul-kothari it would have been great to have this update under "breaking changes" in the release notes here: #10282
(I do see them being mentioned further down the list)

@LeilaWang
Copy link
Contributor

Sorry for the confusion! We will also change the unencrypted logs to be an array. But since there are many changes happening on the public side, this has been given slightly lower priority. But this inconsistency is just temporary, and we will make sure to add it to breaking changes next time. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from-community This originated from the community :) help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants