Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Simplenote iOS metadata automation not detecting en-US #1684

Open
mokagio opened this issue Nov 2, 2024 · 1 comment
Open

Fix Simplenote iOS metadata automation not detecting en-US #1684

mokagio opened this issue Nov 2, 2024 · 1 comment
Assignees
Labels
bug Something isn't working.

Comments

@mokagio
Copy link
Contributor

mokagio commented Nov 2, 2024

During the 4.55 finalization, I got this error in ASC

Image

Turns out the en-US "What's new" metadata had not been uploaded...

That is confirmed by looking at the CI logs

[14:20:02]: Detected languages: ["ar-SA", "de-DE", "default", "es-ES", "fr-FR", "he", "id", "it", "ja", "ko", "nl-NL", "pt-BR", "ru", "sv", "tr", "zh-Hans", "zh-Hant"]

I worked around this manually in the context of 4.55 for time constraints by adding the release notes in ASC myself, but this ought to be fixed before handing over to developers.


Two ideas:

  • Update Fastlane to latest version—seldom hurts
  • Move copyright.txt from metadata/ to metadata/defaults/ (see the CI logs). Maybe having the file there somehow confuses the use of metadata/default/ for en-US?
  • Add something to metadata/en-US/ (currently empyt) so it's picked up
@mokagio mokagio added the bug Something isn't working. label Nov 2, 2024
@mokagio mokagio self-assigned this Nov 2, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@mokagio mokagio changed the title Fix metadata automation not detecting en-US Fix Simplenote iOS metadata automation not detecting en-US Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants