You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe
The filtering mechanism in Storage for the "get many" instances endpoint isn't implemented in the controller, but in the InstanceRepository class. The result being that LocalTest doesn't have any form of filtering on the matching endpoint. It is currently actually resulting in a NotImplementedException.
Describe the solution you'd like
This could be fixed in LocalTest by reimplementing the query logic and applying that to a list of all instances. In Storage the query is made before the request is sent to CosmosDB, but in LocalTest the filtering can be done on the complete list of all instances. I hope it is possible to use the same IQueryBuilder in both cases.
Describe alternatives you've considered
As an addition to this we could rewrite of the logic in Storage as well as LocalTest. I would like to have moved the filtering logic out of InstanceRepository. The construction of the Query could be done in a helper class of some kind or a "business logic service".
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
SandGrainOne
changed the title
LocalTest doesn't filter instances based on the query parameters
LocalTest is missing an implementation for "get many instances"
Oct 27, 2020
Moved issue to new repository. Quite old issue as well, so close if this feature is no longer requested by the app developers or you don't see a need for it.
Is your feature request related to a problem? Please describe
The filtering mechanism in Storage for the "get many" instances endpoint isn't implemented in the controller, but in the InstanceRepository class. The result being that LocalTest doesn't have any form of filtering on the matching endpoint. It is currently actually resulting in a NotImplementedException.
Describe the solution you'd like
This could be fixed in LocalTest by reimplementing the query logic and applying that to a list of all instances. In Storage the query is made before the request is sent to CosmosDB, but in LocalTest the filtering can be done on the complete list of all instances. I hope it is possible to use the same IQueryBuilder in both cases.
Describe alternatives you've considered
As an addition to this we could rewrite of the logic in Storage as well as LocalTest. I would like to have moved the filtering logic out of InstanceRepository. The construction of the Query could be done in a helper class of some kind or a "business logic service".
Additional context
The text was updated successfully, but these errors were encountered: