Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalTest is missing an implementation for "get many instances" #30

Open
SandGrainOne opened this issue Oct 27, 2020 · 1 comment
Open
Labels
kind/feature-request New feature or request

Comments

@SandGrainOne
Copy link
Member

SandGrainOne commented Oct 27, 2020

Is your feature request related to a problem? Please describe

The filtering mechanism in Storage for the "get many" instances endpoint isn't implemented in the controller, but in the InstanceRepository class. The result being that LocalTest doesn't have any form of filtering on the matching endpoint. It is currently actually resulting in a NotImplementedException.

Describe the solution you'd like

This could be fixed in LocalTest by reimplementing the query logic and applying that to a list of all instances. In Storage the query is made before the request is sent to CosmosDB, but in LocalTest the filtering can be done on the complete list of all instances. I hope it is possible to use the same IQueryBuilder in both cases.

Describe alternatives you've considered

As an addition to this we could rewrite of the logic in Storage as well as LocalTest. I would like to have moved the filtering logic out of InstanceRepository. The construction of the Query could be done in a helper class of some kind or a "business logic service".

Additional context

Add any other context or screenshots about the feature request here.

@SandGrainOne SandGrainOne added the kind/feature-request New feature or request label Oct 27, 2020
@SandGrainOne SandGrainOne changed the title LocalTest doesn't filter instances based on the query parameters LocalTest is missing an implementation for "get many instances" Oct 27, 2020
@SandGrainOne SandGrainOne transferred this issue from Altinn/altinn-studio Jan 4, 2023
@acn-sbuad acn-sbuad transferred this issue from Altinn/altinn-storage Mar 10, 2023
@acn-sbuad
Copy link
Contributor

Moved issue to new repository. Quite old issue as well, so close if this feature is no longer requested by the app developers or you don't see a need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants