Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistants redirect to settings if no token yet #566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Nov 27, 2024

Screenshot 2024-11-27 at 3 20 52 pm image

If a user has not yet added an API Services token, nor is there a system-wide token for that API Service, then a small lock is shown on each Assistant; and when you click it you are taken to the API Services page.

@drnic drnic force-pushed the collect-ai-api-token branch from 415f9a7 to 7fc1573 Compare November 27, 2024 06:27
@drnic drnic marked this pull request as ready for review November 27, 2024 06:34
Copy link
Contributor

@krschacht krschacht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change. The lock doesn't signal to me mis-configured, and when you click the assistant in order to see why it's locked then you land on that page and it's not immediately obvious why you're staring at this settings page.

What about this... immediately after signing up, I think it's probably clearer for the user to land on the new conversation view since this is really familiar. It's orienting to take a second and take in this interface that you should recognize. Soon you try typing a message and then are informed of the issue with the API key. However, the instructions are not the easiest to follow. Their multiple steps and you can easily go to the Settings page and end up clicking the assistant in the left sidebar and be really confused since you don't see an API key field there.

How about we keep the user error message which is displayed, but we improve that error message so that it actually includes a direct link to the appropriate API Services page? The error message could show:

(You need to enter a valid API key for Anthropic to use Claude. Click to visit the Settings > API Services > Anthropic and enter your token. You'll also find instructions for how to get it.)
But that bold part should be a clickable hyperlink.

This has the added benefit that when your API key expires or you get billing issues, these also throw API exceptions, and the error message will be improved for those situations as well whereas this lock approach only attempts to improve the "missing" scenario and not the other "issue with keys" scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants