Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logging for workers #517

Merged
merged 7 commits into from
Oct 18, 2024
Merged

fix logging for workers #517

merged 7 commits into from
Oct 18, 2024

Conversation

jlvallelonga
Copy link
Contributor

workers weren't logging correctly so this fixes them

@jlvallelonga
Copy link
Contributor Author

solidqueue is still logging heartbeat updates every minute so I'll continue working on a fix for that, but wanted to push this as a draft first

jlvallelonga
jlvallelonga commented Oct 15, 2024
View reviewed changes
config/initializers/solid_queue_extension.rb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to get a PR in for solidqueue to make this an official option

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rails/solid_queue#389

@jlvallelonga jlvallelonga marked this pull request as ready for review October 15, 2024 07:55
krschacht
krschacht approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@krschacht krschacht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, if you’re done with this one feel free to merge in. I couldn’t tell if there was something else you wanted to add to it.

@jlvallelonga jlvallelonga merged commit 07610fd into main Oct 18, 2024
6 checks passed
@jlvallelonga jlvallelonga deleted the chore/fix_logger_for_workers branch October 18, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krschacht krschacht krschacht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlvallelonga @krschacht