Hide vacant tags config option on River #3823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetwistedlogic
commented
Dec 12, 2024
src/modules/river/tags.cpp
Outdated
| buttons_[i].get_style_context()->add_class("focused"); | ||
| } else { | ||
| buttons_[i].get_style_context()->remove_class("focused"); | ||
| if (hide_vacant && !buttons_[i].get_style_context()->has_class("occupied")) { |
There was a problem hiding this comment.
This is a bit hacky but I'm not sure of a better solution.
Without this extra condition, tags will remain permanently visible as long as they have been focused (even after moving to another tag).
thetwistedlogic
changed the title
This fixes an edge case where focused tags would get hidden if all clients on a tag get killed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to hide vacant tags on river. Vacant means not occupied and not focused.
Addresses:
#3790
#2537