fix mpd module hang after suspend #3793
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been having this annoying issue for a while, in which after waking up from a long suspend the MPD module is not updating anymore.
Clicking the MPD module icon does trigger play/pause events but it does not show the active song anymore.
I think I finally manage to track it down to a broken idle connection, and this PR fixes the issue.
How to reproduce
Run:
systemctl suspend
go get a beer, come back after a lot of time, and the MPD module will not update anymore.
If you don't have a lot of time, I managed to reproduce similar symptoms by killing the socket(s) using
ss
:The mpd module will not update anymore, even though it responds to clicks.