Add dwl/tags option to show only active tags #3504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ty3uK
commented
Aug 4, 2024
| const bool show_only_viable = config_["show-only-viable"].asBool(); | ||
| if (show_only_viable) { | ||
| if (clients > 0 || state & (TAG_ACTIVE | TAG_URGENT)) { | ||
| button.show(); |
There was a problem hiding this comment.
Not sure if blindly calling show/hide is OK, was thinking about button.is_visible() checks.
There was a problem hiding this comment.
show and hide are deprecated since 4.10.
Use gtk_widget_set_visible() instead:
if (clients || state & (TAG_ACTIVE | TAG_URGENT)) {
button.set_visible(true);
} else {
button.set_visible(false);
}
Alexays
force-pushed
the
master
branch
2 times, most recently
from
d623a89 to
a4d31ab
Compare
|
Would it be possible to have similar feature in River tags? |
Iwwww
reviewed
Nov 25, 2024
| const bool show_only_viable = config_["show-only-viable"].asBool(); | ||
| if (show_only_viable) { | ||
| if (clients > 0 || state & (TAG_ACTIVE | TAG_URGENT)) { | ||
| button.show(); |
There was a problem hiding this comment.
show and hide are deprecated since 4.10.
Use gtk_widget_set_visible() instead:
if (clients || state & (TAG_ACTIVE | TAG_URGENT)) {
button.set_visible(true);
} else {
button.set_visible(false);
}|
|
||
| const bool show_only_viable = config_["show-only-viable"].asBool(); | ||
| if (show_only_viable) { | ||
| if (clients > 0 || state & (TAG_ACTIVE | TAG_URGENT)) { |
There was a problem hiding this comment.
You can just use clients in the condition without > 0:
if (clients || state & (TAG_ACTIVE | TAG_URGENT)) {
Just implemented this over here: #3823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not an experienced C++ developer at all, will be glad to hear any advice 🙏
Generally, it's like
sway/workspacesbehavior.