Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3375/#3363/mpris: enable tooltip markup/systemd-failed-units: enable tooltip #3460

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Issue #3375/#3363/mpris: enable tooltip markup/systemd-failed-units: enable tooltip #3460

wants to merge 6 commits into from

Conversation

RobertMueller2
Copy link
Contributor

@RobertMueller2 RobertMueller2 commented Jul 20, 2024 •
edited
Loading

Closes #3363
Closes #3375
Closes #2357

EDIT: includes former PR #3458

  • Adds tooltip-with-markup config option to AModule (default true). Modules can use this through the method tooltipMarkupEnabled(), but don't have to
  • adds usage of this method to mpris for its tooltip
  • also for systemd-failed-units

khaneliman
khaneliman approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working here.
image

@RobertMueller2 RobertMueller2 changed the title [Draft] Issue #3363/systemd-failed-units: enable tooltip Issue #3375/#3363/systemd-failed-units and mpris: enable tooltip Jul 21, 2024
@RobertMueller2 RobertMueller2 mentioned this pull request Jul 21, 2024
Closed
@RobertMueller2 RobertMueller2 marked this pull request as ready for review July 21, 2024 12:25
@RobertMueller2 RobertMueller2 changed the title Issue #3375/#3363/systemd-failed-units and mpris: enable tooltip Issue #3375/#3363/mpris: enable tooltip markup/systemd-failed-units: enable tooltip Jul 22, 2024
@RobertMueller2
Copy link
Contributor Author

I think the tooltip could do with escaping, I'll add that when I get a chance.

@RobertMueller2 RobertMueller2 marked this pull request as draft July 23, 2024 06:11
@RobertMueller2 RobertMueller2 marked this pull request as ready for review July 23, 2024 14:06
@Alexays Alexays force-pushed the master branch 2 times, most recently from d623a89 to a4d31ab Compare September 13, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RobertMueller2 @khaneliman