Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boardAux when new ERTP brands are added #8627

Open
turadg opened this issue Dec 6, 2023 · 2 comments
Open

update boardAux when new ERTP brands are added #8627

turadg opened this issue Dec 6, 2023 · 2 comments
Labels
contract-upgrade enhancement New feature or request hygiene Tidying up around the house test triaged_2024

Comments

@turadg
Copy link
Member

turadg commented Dec 6, 2023

What is the Problem Being Solved?

The published.boardAux was populated by upgrade-walletFactory-proposal when is was upgraded from incarnation 0 to 1. As new brands are added to agoricNames.brand, boardAux does not get them.

Description of the Design

Test that addAssetToVault ends up with the new ERTP brand in boardAux.

Consider a helper utility that adds the ERTP to both agoricNames.brand and boardAux.

Whenever iterating over agoricNames.brand for ERTP brands, omit known non-ERTP brands such as timer (TimerBrand) to avoid errors like TypeError: target has no method "getDisplayInfo", has ["isMyClock","isMyTimerService"])

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@turadg turadg added enhancement New feature or request hygiene Tidying up around the house test contract-upgrade labels Dec 6, 2023
@dckc
Copy link
Member

dckc commented Dec 6, 2023

Consider a helper utility that adds the ERTP to both agoricNames.brand and boardAux.

We have a way of putting brands into agoricNames that's nicely integrated with the permit structure; for example, see:

I wonder if there's a way to get that mechanism to populate boardAux automatically.

@dckc
Copy link
Member

dckc commented Dec 6, 2023

Test that addAssetToVault ends up with the new ERTP brand in boardAux.

startPSM too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request hygiene Tidying up around the house test triaged_2024
Projects
None yet
Development

No branches or pull requests

3 participants