Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smart wallet state grows with each offer #6065

Closed
dckc opened this issue Aug 26, 2022 · 3 comments · Fixed by #6078 or #6095
Closed

smart wallet state grows with each offer #6065

dckc opened this issue Aug 26, 2022 · 3 comments · Fixed by #6078 or #6095
Assignees
@dckc
Labels
bug Something isn't working resource-exhaustion Threats to availability from resource exhaustion attacks wallet
Milestone
Mainnet 1 RC0

Comments

@dckc
Copy link
Member

dckc commented Aug 26, 2022 •
edited by turadg
Loading

Describe the bug

The published state includes a list of all offers, past and present.

Expected behavior

that the offer is removed when:

  • the offerResult does not support continuing offers (all PSM offers, but not vault creation)
  • or the offerResult is an error (since you cannot continue that)
  • then once the offer is exited, the state update is reported via subscription and the offer is deleted from the wallet

cc @warner @samsiegart @turadg @dtribble @michaelfig
@dckc dckc added bug Something isn't working wallet resource-exhaustion Threats to availability from resource exhaustion attacks pso labels Aug 26, 2022
@Tartuffo Tartuffo removed the pso label Aug 26, 2022
@dckc dckc mentioned this issue Aug 27, 2022
Merged
@mergify mergify bot closed this as completed in #6078 Aug 29, 2022
@dckc
Copy link
Member Author

dckc commented Aug 29, 2022

we're seeing huge state writes. wallets and payments are important to consider

@dckc dckc reopened this Aug 29, 2022
@dckc
Copy link
Member Author

dckc commented Aug 30, 2022

@gibson042 helped me sketch a test to write large strings to the chainStorage vat:
https://github.com/Agoric/agoric-sdk/blob/dc-wallet-prune2/packages/vats/test/swingsetTests/flatPerf/test-chainStorage-growth.js

@dckc dckc mentioned this issue Aug 31, 2022
Merged
@mergify mergify bot closed this as completed in #6095 Aug 31, 2022
@turadg
Copy link
Member

turadg commented Aug 31, 2022

@dckc do we know that 6095 solved the problem?

@Tartuffo Tartuffo added this to the Mainnet 1 RC0 milestone Sep 13, 2022
@dckc dckc mentioned this issue Sep 24, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dckc dckc

Labels
bug Something isn't working resource-exhaustion Threats to availability from resource exhaustion attacks wallet
Projects
None yet
Milestone
Mainnet 1 RC0
3 participants
@turadg @dckc @Tartuffo