-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong numbering in pagination #395
Comments
Indeed, it was utterly broken. 😬 Thanks for the report @csl24 @progranime |
You can test right now the fix with: npm install --save github:AdeleD/react-paginate#v8.0.1 https://github.com/AdeleD/react-paginate/releases/tag/v8.0.1 |
@MonsieurV Done |
Thx @AdeleD Here the original snippet with the bug fixed (react-paginate bumped to v8.0.1): https://codepen.io/monsieurv/pen/MWvMOBE |
Hello!
When testing the library, I noticed that the page numbering is not correct in some cases.
I found that the error is related to the implementation "Fix the breaking algorithm to not create breaks for only one page" (see: #270) in the v8.0.0, because in v7.1.3 there is no problem of enumeration.
I add a link to test the behavior: codepen
The text was updated successfully, but these errors were encountered: