Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property 'findLastIndex' does not exist on type 'lineDataItem[]' #31

Closed
stereodenis opened this issue Jul 30, 2024 · 2 comments
Closed

Property 'findLastIndex' does not exist on type 'lineDataItem[]' #31

stereodenis opened this issue Jul 30, 2024 · 2 comments

Comments

@stereodenis
Copy link

"gifted-charts-core": "^0.1.21" from "react-native-gifted-charts": "1.4.22"

image
@stereodenis stereodenis mentioned this issue Jul 30, 2024
Closed
@Abhinandan-Kushwaha
Copy link
Owner

Hi @stereodenis
Thanks for reporting this issue.

It has been fixed with this PR- #33

@dumihi313
Copy link

dumihi313 commented Aug 2, 2024 •
edited
Loading

Why don't we keep this code findLastIndex()?
I can see this MR fix leads to low performance and wrong, even crash result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stereodenis @Abhinandan-Kushwaha @dumihi313