New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: replace explicit checks for CMAKE_BUILD_TYPE #2447

Closed

3 tasks

dweindl opened this issue May 14, 2024 · 0 comments

Closed

3 tasks

cmake: replace explicit checks for CMAKE_BUILD_TYPE #2447

dweindl opened this issue May 14, 2024 · 0 comments

Assignees

Labels

cmake

Member

dweindl commented May 14, 2024 •

edited

Loading

In our CMakeLists.txt:

Don't change CMAKE_BUILD_TYPE from within CMakeLists.txt. This should be passed to cmake at configure-time instead. This will also fix IMPORTED_LOCATION not set for imported target "Upstream::amici" #2442.
Don't check for CMAKE_BUILD_TYPE explicitly -- not compatible with multi-config generators
Set MAP_IMPORTED_CONFIG_CONFIG

See also https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#build-configurations

dweindl added the cmake label

dweindl mentioned this issue

Specify cmake build types and require cmake-build-extension==0.6.0 #2445

Merged

dweindl self-assigned this

dweindl closed this as completed in

7f7be0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment