Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid leaving .part files in the backend (to the best of our ability) #65

Open
ALSchwalm opened this issue Jun 10, 2020 · 1 comment · May be fixed by #136
Open

Avoid leaving .part files in the backend (to the best of our ability) #65

ALSchwalm opened this issue Jun 10, 2020 · 1 comment · May be fixed by #136
Labels
good first issue Good for newcomers

Comments

@ALSchwalm
Copy link
Owner

It is generally impossible to completely ensure that no files are left behind when doing an image download, but we should at least try to clean up any partial file downloads that are around if we receive SIGINT.
@ALSchwalm ALSchwalm mentioned this issue Jun 10, 2020
Closed
@ALSchwalm ALSchwalm added the good first issue Good for newcomers label Jun 12, 2020
@ALSchwalm
Copy link
Owner Author

This should really be a more general solution. We have lots of places where we generate intermediate files. We need some way to register a file to be cleaned up regardless of how we exit. Maybe using an atexit handler or something?

@benfogle benfogle linked a pull request May 28, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete intermediate download files on error. benfogle/transient
1 participant
@ALSchwalm