Skip to content

Commit

Permalink
fix(docker): fixed Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
@serge1peshcoff
serge1peshcoff committed Sep 1, 2019
1 parent c676840 commit d6e3def
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions docker/docker-compose.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ services:
- 8084
environment:
BUGSNAG_KEY: 6f6a7c00507fceca0818c48405dbd2a6
secrets:
- mail_user
- mail_password
PW_POSTGRES: ${PW_POSTGRES}
labels:
- "traefik.backend=oms-events"
- "traefik.port=8084"
Expand All @@ -46,8 +44,3 @@ volumes:
driver: "local"
shared:
driver: "local"

networks:
default:
external:
name: OMS

5 comments on commit d6e3def

@linuxbandit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default network must always be specified, or there could be unexpected errors!

@serge1peshcoff
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linuxbandit it's also not specified in core, I've took the reference from there. But anyway, we're not running it standalone except for tests, so it shouldn't be an issue right?

@linuxbandit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf i replied via email and it's not here!

@linuxbandit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here: That's exactly the problem, in standalone we don't care what is the default network, but when we have to make all of them join the default one we need it.

I suggest that for the best, state-of-the-art docker-compose manifests you check on github.com/aegee/myaegee because there I have straightened all the little imperfections (for instance, it's better to quote everything, etc etc)

@serge1peshcoff
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, can you make a task to add the default network to all docker-compose.yml files and assign it to me? as I've removed all of them :D
need to update the CircleCI config so it wouldn't break because of non-existant network

Please sign in to comment.