fix(events): disallow updating picture in some cases #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 734 736 +2
Branches 168 168
=========================================
+ Hits 734 736 +2
Continue to review full report at Codecov.
|
serge1peshcoff
approved these changes
Oct 22, 2021
serge1peshcoff
pushed a commit
that referenced
this pull request
Oct 22, 2021
## [1.3.10](1.3.9...1.3.10) (2021-10-22) ### Bug Fixes * **events:** disallow updating picture in some cases ([#608](#608)) ([ebaedf9](ebaedf9))
|
🎉 This PR is included in version 1.3.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@serge1peshcoff when uploading an image and saving the event afterwards, it would keep the id of the former image causing it not to update (at least, that's the hypothesis). This should fix this issue, will do the same for the other places where we upload images.