feat(MA-6): add additional fields to events #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HassanCehef
changed the title
HassanCehef
changed the title
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 676 676
Branches 141 141
=========================================
Hits 676 676
Continue to review full report at Codecov.
|
WikiRik
reviewed
Jul 28, 2020
HassanCehef
added a commit
to AEGEE/frontend
that referenced
this pull request
Sep 19, 2020
TODO: - [ ] validate the wording, the help text, and the position of the fields - [ ] fix the SingleView, where fields are printed when they should not. I think a side effect of this is that people editing their current events will be forced to fill two new mandatory fields: accommodation type, and number of meals served. Both of which do not make sense in the current context where everything happens online This must be merged only in sync with the PR on AEGEE/events#314
2 tasks
WikiRik
reviewed
Sep 19, 2020
HassanCehef
commented
Sep 19, 2020
better random generator for tests
WikiRik
approved these changes
Sep 30, 2020
WikiRik
pushed a commit
to AEGEE/frontend
that referenced
this pull request
Sep 30, 2020
* feat(MA-6): add additional fields to events (front) Addition of a few new fields that will be useful for offline events (best time for those :D). EQAC requested five extra fields A further PR will improve the creation of online-only events, where more fields will be hidden. * feat(ma-6): add additional fields to events TODO: - [ ] validate the wording, the help text, and the position of the fields - [ ] fix the SingleView, where fields are printed when they should not. I think a side effect of this is that people editing their current events will be forced to fill two new mandatory fields: accommodation type, and number of meals served. Both of which do not make sense in the current context where everything happens online This must be merged only in sync with the PR on AEGEE/events#314 * added tip on how to fill the optional programme
serge1peshcoff
pushed a commit
to AEGEE/frontend
that referenced
this pull request
Sep 30, 2020
# [1.15.0](1.14.0...1.15.0) (2020-09-30) ### Features * **MA-6:** add additional fields to events (front) ([#601](#601)) ([7ad8ad6](7ad8ad6)), closes [AEGEE/events#314](AEGEE/events#314)
serge1peshcoff
pushed a commit
that referenced
this pull request
Sep 30, 2020
# [1.2.0](1.1.2...1.2.0) (2020-09-30) ### Features * **MA-6:** add additional fields to events ([#314](#314)) ([bd9502f](bd9502f))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EQAC requested five new fields to be added when events are created.
This must be merged in conjunction with the corresponding change in frontend