Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mode=strict throws when plaintext in database #107

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: mode=strict throws when plaintext in database #107

wants to merge 1 commit into from

Conversation

richmirza
Copy link

Closes #106

I have a test locally too but I'm not sure of the process to update the test / integration SQLite DBs?

franky47
franky47 requested changes Apr 24, 2024
View reviewed changes
src/encryption.ts
@@ -177,6 +177,9 @@ export function decryptOnRead<Models extends string, Actions extends string>(
}) {
try {
if (!cloakedStringRegex.test(cipherText)) {
if (fieldConfig.strictDecryption) {
throw new Error('Value is not encrypted and mode=strict')
Copy link
Member

@franky47 franky47 Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Could you move the error message to the errors.ts file, to add some context (model/field) please? Having this in logs helps a lot debugging those kind of errors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be wrapped in the FieldDecryptionError in the catch?

@franky47
Copy link
Member

Regarding testing, you could:

  1. Add a model dedicated to this test, that has two encrypted fields, one in strict mode and one without
  2. Run yarn generate & DATABASE_URL="file:./db.test.sqlite" prisma db push to apply the schema changes to the SQLite template database
  3. In the intergration test file, inject some cleartext data the way you did in Plaintext values with mode=strict do not throw errors #106 (using a raw query)
  4. Check that a read on that table that matches a cleartext strict field throws an error, but that cleartext on the non-strict field doesn't throw

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franky47 franky47 franky47 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plaintext values with mode=strict do not throw errors
2 participants
@richmirza @franky47