Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal & external links to templates in leading-projects.md #4016

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Fix internal & external links to templates in leading-projects.md #4016

merged 7 commits into from
Nov 26, 2024

Conversation

alexsobledotgov
Copy link
Contributor

@alexsobledotgov alexsobledotgov commented Nov 26, 2024 •
edited
Loading

What changes does this make?

  • Fixes bug -- links to templates in leading projects page are currently broken, this PR fixes
  • Adds links to all templates added in Update 18F templates in Handbook #4005
  • Clarifies documentation on what download shortcode does

👁️ Preview build pages

Issue

@alexsobledotgov alexsobledotgov marked this pull request as ready for review November 26, 2024 18:34
@alexsobledotgov alexsobledotgov requested a review from a team as a code owner November 26, 2024 18:34
mgwalker
mgwalker reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@mgwalker mgwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo and then this is good to go. Thanks for improving that documentation!

pages/updating-the-handbook/shortcodes.md Outdated Show resolved Hide resolved
jskinne3
jskinne3 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@alexsobledotgov alexsobledotgov merged commit 09678e5 into main Nov 26, 2024
8 checks passed
@alexsobledotgov alexsobledotgov deleted the ars/update-leading-projects-templates branch November 26, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgwalker mgwalker mgwalker left review comments

@jskinne3 jskinne3 jskinne3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsobledotgov @jskinne3 @mgwalker